From 506ea8a3b84b03ca43ab730ef97b1ab9e52838aa Mon Sep 17 00:00:00 2001
From: Mark Veidemanis <m@zm.is>
Date: Tue, 3 Mar 2026 17:45:50 +0000
Subject: [PATCH] Remove raw IDs from some places

---
 core/templates/pages/command-routing.html | 130 +++++++++++-----------
 core/templates/pages/tasks-group.html     |   7 +-
 core/views/automation.py                  |   4 +
 core/views/tasks.py                       |  15 +++
 4 files changed, 87 insertions(+), 69 deletions(-)

diff --git a/core/templates/pages/command-routing.html b/core/templates/pages/command-routing.html
index 5c49525..f06d848 100644
--- a/core/templates/pages/command-routing.html
+++ b/core/templates/pages/command-routing.html
@@ -304,72 +304,74 @@
             </div>
           </div>
 
-          <div class="columns">
-            <div class="column">
-              <h3 class="title is-7">Actions</h3>
-              <p class="help">Enable/disable each step and use the reorder capsule to change execution order.</p>
-              <table class="table is-fullwidth is-striped is-size-7">
-                <thead>
-                  <tr><th scope="col">Type</th><th scope="col">Enabled</th><th scope="col">Reorder</th><th scope="col">Actions</th></tr>
-                </thead>
-                <tbody>
-                  {% for action_row in profile.actions.all %}
-                    <tr>
-                      <td>
-                        {% if action_row.action_type == "extract_bp" %}Extract Business Plan
-                        {% elif action_row.action_type == "save_document" %}Save Document
-                        {% elif action_row.action_type == "post_result" %}Post Result
-                        {% else %}{{ action_row.action_type }}
-                        {% endif %}
-                      </td>
-                      <td>{{ action_row.enabled }}</td>
-                      <td>
-                        <span class="command-order-capsule">
-                          <form method="post" class="command-order-capsule-form" aria-label="Move action {{ action_row.action_type }} up for {{ profile.name }}">
-                            {% csrf_token %}
-                            <input type="hidden" name="action" value="action_move">
-                            <input type="hidden" name="command_action_id" value="{{ action_row.id }}">
-                            <input type="hidden" name="direction" value="up">
-                            {% if scope_service and scope_identifier %}
-                              <input type="hidden" name="service" value="{{ scope_service }}">
-                              <input type="hidden" name="identifier" value="{{ scope_identifier }}">
-                            {% endif %}
-                            <button class="button is-small is-light command-order-btn" type="submit" {% if forloop.first %}disabled{% endif %} aria-label="Move up">▲</button>
-                          </form>
-                          <form method="post" class="command-order-capsule-form" aria-label="Move action {{ action_row.action_type }} down for {{ profile.name }}">
-                            {% csrf_token %}
-                            <input type="hidden" name="action" value="action_move">
-                            <input type="hidden" name="command_action_id" value="{{ action_row.id }}">
-                            <input type="hidden" name="direction" value="down">
-                            {% if scope_service and scope_identifier %}
-                              <input type="hidden" name="service" value="{{ scope_service }}">
-                              <input type="hidden" name="identifier" value="{{ scope_identifier }}">
-                            {% endif %}
-                            <button class="button is-small is-light command-order-btn" type="submit" {% if forloop.last %}disabled{% endif %} aria-label="Move down">▼</button>
-                          </form>
-                        </span>
-                      </td>
-                      <td>
-                        <form method="post" aria-label="Update action {{ action_row.action_type }} for {{ profile.name }}">
-                          {% csrf_token %}
-                          <input type="hidden" name="action" value="action_update">
-                          <input type="hidden" name="command_action_id" value="{{ action_row.id }}">
-                          {% if scope_service and scope_identifier %}
-                            <input type="hidden" name="service" value="{{ scope_service }}">
-                            <input type="hidden" name="identifier" value="{{ scope_identifier }}">
+          {% if profile.show_actions_editor %}
+            <div class="columns">
+              <div class="column">
+                <h3 class="title is-7">Actions</h3>
+                <p class="help">Enable/disable each step and use the reorder capsule to change execution order.</p>
+                <table class="table is-fullwidth is-striped is-size-7">
+                  <thead>
+                    <tr><th scope="col">Type</th><th scope="col">Enabled</th><th scope="col">Reorder</th><th scope="col">Actions</th></tr>
+                  </thead>
+                  <tbody>
+                    {% for action_row in profile.actions.all %}
+                      <tr>
+                        <td>
+                          {% if action_row.action_type == "extract_bp" %}Extract Business Plan
+                          {% elif action_row.action_type == "save_document" %}Save Document
+                          {% elif action_row.action_type == "post_result" %}Post Result
+                          {% else %}{{ action_row.action_type }}
                           {% endif %}
-                          <label class="checkbox is-size-7"><input type="checkbox" name="enabled" value="1" {% if action_row.enabled %}checked{% endif %}> enabled</label>
-                          <button class="button is-link is-light is-small" type="submit">Save</button>
-                        </form>
-                      </td>
-                    </tr>
-                  {% empty %}
-                    <tr><td colspan="4">No actions.</td></tr>
-                  {% endfor %}
-                </tbody>
-              </table>
+                        </td>
+                        <td>{{ action_row.enabled }}</td>
+                        <td>
+                          <span class="command-order-capsule">
+                            <form method="post" class="command-order-capsule-form" aria-label="Move action {{ action_row.action_type }} up for {{ profile.name }}">
+                              {% csrf_token %}
+                              <input type="hidden" name="action" value="action_move">
+                              <input type="hidden" name="command_action_id" value="{{ action_row.id }}">
+                              <input type="hidden" name="direction" value="up">
+                              {% if scope_service and scope_identifier %}
+                                <input type="hidden" name="service" value="{{ scope_service }}">
+                                <input type="hidden" name="identifier" value="{{ scope_identifier }}">
+                              {% endif %}
+                              <button class="button is-small is-light command-order-btn" type="submit" {% if forloop.first %}disabled{% endif %} aria-label="Move up">▲</button>
+                            </form>
+                            <form method="post" class="command-order-capsule-form" aria-label="Move action {{ action_row.action_type }} down for {{ profile.name }}">
+                              {% csrf_token %}
+                              <input type="hidden" name="action" value="action_move">
+                              <input type="hidden" name="command_action_id" value="{{ action_row.id }}">
+                              <input type="hidden" name="direction" value="down">
+                              {% if scope_service and scope_identifier %}
+                                <input type="hidden" name="service" value="{{ scope_service }}">
+                                <input type="hidden" name="identifier" value="{{ scope_identifier }}">
+                              {% endif %}
+                              <button class="button is-small is-light command-order-btn" type="submit" {% if forloop.last %}disabled{% endif %} aria-label="Move down">▼</button>
+                            </form>
+                          </span>
+                        </td>
+                        <td>
+                          <form method="post" aria-label="Update action {{ action_row.action_type }} for {{ profile.name }}">
+                            {% csrf_token %}
+                            <input type="hidden" name="action" value="action_update">
+                            <input type="hidden" name="command_action_id" value="{{ action_row.id }}">
+                            {% if scope_service and scope_identifier %}
+                              <input type="hidden" name="service" value="{{ scope_service }}">
+                              <input type="hidden" name="identifier" value="{{ scope_identifier }}">
+                            {% endif %}
+                            <label class="checkbox is-size-7"><input type="checkbox" name="enabled" value="1" {% if action_row.enabled %}checked{% endif %}> enabled</label>
+                            <button class="button is-link is-light is-small" type="submit">Save</button>
+                          </form>
+                        </td>
+                      </tr>
+                    {% empty %}
+                      <tr><td colspan="4">No actions.</td></tr>
+                    {% endfor %}
+                  </tbody>
+                </table>
+              </div>
             </div>
-          </div>
+          {% endif %}
 
           <form method="post" style="margin-top: 0.75rem;" aria-label="Delete profile {{ profile.name }}">
             {% csrf_token %}
diff --git a/core/templates/pages/tasks-group.html b/core/templates/pages/tasks-group.html
index 5364f12..6140d0f 100644
--- a/core/templates/pages/tasks-group.html
+++ b/core/templates/pages/tasks-group.html
@@ -2,7 +2,7 @@
 {% block content %}
 <section class="section"><div class="container">
   <h1 class="title is-4">Group Tasks: {{ channel_display_name }}</h1>
-  <p class="subtitle is-6">{{ service_label }} · {{ identifier }}</p>
+  <p class="subtitle is-6">{{ service_label }}</p>
   <article class="box">
     <h2 class="title is-6">Create Or Map Project</h2>
     <form method="post" style="margin-bottom: 0.7rem;">
@@ -68,10 +68,7 @@
               <td>{{ row.project.name }}</td>
               <td>{% if row.epic %}{{ row.epic.name }}{% else %}-{% endif %}</td>
               <td>
-                <div><code>{{ row.service }} · {{ row.channel_identifier }}</code></div>
-                {% if channel_display_name %}
-                  <p class="is-size-7 has-text-dark" style="margin-top:0.2rem;">{{ channel_display_name }}</p>
-                {% endif %}
+                <div>{{ row.display_service_label }} · {{ row.display_channel_name }}</div>
               </td>
               <td>{{ row.enabled }}</td>
               <td><a class="button is-small is-light" href="{% url 'tasks_project' project_id=row.project_id %}">Open Project</a></td>
diff --git a/core/views/automation.py b/core/views/automation.py
index a2a80b9..6a8b3a4 100644
--- a/core/views/automation.py
+++ b/core/views/automation.py
@@ -79,6 +79,7 @@ class CommandRoutingSettings(LoginRequiredMixin, View):
         preview_profile_id = str(request.GET.get("preview_profile_id") or "").strip()
         for profile in profiles:
             policies = ensure_variant_policies_for_profile(profile)
+            profile.show_actions_editor = str(profile.slug or "").strip() != "bp"
             if str(profile.slug or "").strip() == "bp":
                 keys = BP_VARIANT_KEYS
             else:
@@ -172,6 +173,9 @@ class CommandRoutingSettings(LoginRequiredMixin, View):
                 action_type="extract_bp",
                 defaults={"enabled": True, "position": 0},
             )
+            # Keep legacy action rows in storage for compatibility and for
+            # potential reuse by non-bp commands; bp UI now relies on
+            # variant policies instead of exposing the generic action matrix.
             CommandAction.objects.get_or_create(
                 profile=profile,
                 action_type="save_document",
diff --git a/core/views/tasks.py b/core/views/tasks.py
index 82e7e12..0a337d0 100644
--- a/core/views/tasks.py
+++ b/core/views/tasks.py
@@ -683,6 +683,21 @@ class TaskGroupDetail(LoginRequiredMixin, View):
             service__in=service_keys,
             channel_identifier__in=variants,
         ).select_related("project", "epic")
+        mappings = list(mappings)
+        for row in mappings:
+            row_channel = _resolve_channel_display(
+                request.user,
+                str(getattr(row, "service", "") or ""),
+                str(getattr(row, "channel_identifier", "") or ""),
+            )
+            row.display_service_label = row_channel.get("service_label") or _service_label(
+                str(getattr(row, "service", "") or "")
+            )
+            row.display_channel_name = (
+                str(row_channel.get("display_name") or "").strip()
+                or str(channel.get("display_name") or "").strip()
+                or "Unknown chat"
+            )
         tasks = (
             DerivedTask.objects.filter(
                 user=request.user,