Use ObjectRead helper for all list and detail views

core/views/callbacks.py

@@ -1,11 +1,8 @@
-import uuid
-
 from django.contrib.auth.mixins import LoginRequiredMixin
 from django.http import HttpResponseBadRequest
-from django.shortcuts import render
-from django.views import View
 
 from core.models import Callback, Hook, Signal
+from core.views import ObjectList
 
 
 def get_callbacks(user, hook=None, signal=None):
@@ -17,21 +14,30 @@ def get_callbacks(user, hook=None, signal=None):
     return callbacks
 
 
-class Callbacks(LoginRequiredMixin, View):
-    allowed_types = ["modal", "widget", "window", "page"]
-    window_content = "window-content/objects.html"
+class Callbacks(LoginRequiredMixin, ObjectList):
     list_template = "partials/callback-list.html"
     page_title = "List of received callbacks"
 
-    async def get(self, request, type, object_type, object_id):
-        if type not in self.allowed_types:
-            return HttpResponseBadRequest
-        template_name = f"wm/{type}.html"
-        unique = str(uuid.uuid4())[:8]
+    context_object_name_singular = "callback"
+    context_object_name = "callbacks"
 
+    list_url_name = "callbacks"
+    list_url_args = ["type", "object_type", "object_id"]
+
+    def get_callbacks(self, user, hook=None, signal=None):
+        if hook:
+            cast = {"hook": hook, "hook__user": user}
+        elif signal:
+            cast = {"signal": signal, "signal__user": user}
+        callbacks = Callback.objects.filter(**cast)
+        return callbacks
+
+    def get_queryset(self, **kwargs):
+        object_type = kwargs.get("object_type")
+        object_id = kwargs.get("object_id")
         if object_type == "hook":
             try:
-                hook = Hook.objects.get(id=object_id, user=request.user)
+                hook = Hook.objects.get(id=object_id, user=self.request.user)
             except Hook.DoesNotExist:
                 message = "Hook does not exist."
                 message_class = "danger"
@@ -40,11 +46,11 @@ class Callbacks(LoginRequiredMixin, View):
                     "class": message_class,
                     "type": type,
                 }
-                return render(request, template_name, context)
-            callbacks = get_callbacks(request.user, hook)
+                return self.render_to_response(context)
+            callbacks = self.get_callbacks(self.request.user, hook)
         elif object_type == "signal":
             try:
-                signal = Signal.objects.get(id=object_id, user=request.user)
+                signal = Signal.objects.get(id=object_id, user=self.request.user)
             except Signal.DoesNotExist:
                 message = "Signal does not exist."
                 message_class = "danger"
@@ -53,20 +59,9 @@ class Callbacks(LoginRequiredMixin, View):
                     "class": message_class,
                     "type": type,
                 }
-                return render(request, template_name, context)
-            callbacks = get_callbacks(request.user, signal=signal)
+                return self.render_to_response(context)
+            callbacks = self.get_callbacks(self.request.user, signal=signal)
         else:
-            callbacks = get_callbacks(request.user)
-        if type == "page":
-            type = "modal"
+            return HttpResponseBadRequest("Invalid object type")
 
-        context = {
-            "title": f"Callbacks ({type})",
-            "unique": unique,
-            "window_content": self.window_content,
-            "list_template": self.list_template,
-            "object_list": callbacks,
-            "type": type,
-            "page_title": self.page_title,
-        }
-        return render(request, template_name, context)
+        return callbacks