Simplify DB object management with Django CRUD helpers

core/views/hooks.py

@@ -1,13 +1,10 @@
 import re
-import uuid
 
 import orjson
 from django.conf import settings
 from django.contrib.auth.mixins import LoginRequiredMixin
 from django.http import HttpResponse, HttpResponseBadRequest
-from django.shortcuts import render
-from django.views import View
-from rest_framework.parsers import FormParser, JSONParser
+from rest_framework.parsers import JSONParser
 from rest_framework.views import APIView
 from serde import ValidationError
 
@@ -16,15 +13,11 @@ from core.lib import market
 from core.lib.serde import drakdoo_s
 from core.models import Callback, Hook
 from core.util import logs
+from core.views import ObjectCreate, ObjectDelete, ObjectList, ObjectUpdate
 
 log = logs.get_logger(__name__)
 
 
-def get_hooks(user):
-    hooks = Hook.objects.filter(user=user)
-    return hooks
-
-
 def extract_price(message):
     result = re.findall("\d+\.\d+", message)  # noqa
     if len(result) != 1:
@@ -72,8 +65,8 @@ class HookAPI(APIView):
             "message": hook_resp.message,
             "period": hook_resp.period,
             "sent": hook_resp.timestamp.sent,
-            "timestamp_trade": hook_resp.timestamp.trade,
-            "trade": hook_resp.market.exchange,
+            "trade": hook_resp.timestamp.trade,
+            "exchange": hook_resp.market.exchange,
             "base": hook_resp.market.item,
             "quote": hook_resp.market.currency,
             "symbol": symbol,
@@ -106,142 +99,32 @@ class HookAPI(APIView):
         return HttpResponse(orjson.dumps(return_data), content_type="application/json")
 
 
-class Hooks(LoginRequiredMixin, View):
-    allowed_types = ["modal", "widget", "window", "page"]
-    window_content = "window-content/hooks.html"
+class HookList(LoginRequiredMixin, ObjectList):
+    # window_content = "window-content/hooks.html"
+    list_template = "partials/hook-list.html"
+    model = Hook
+    context_object_name = "hooks"
+    title = "Hooks"
+    title_singular = "Hook"
+    page_title = "List of active URL endpoints for receiving hooks."
+    page_subtitle = "Add URLs here to receive Drakdoo callbacks. Make then unique!"
 
-    async def get(self, request, type):
-        if type not in self.allowed_types:
-            return HttpResponseBadRequest
-        template_name = f"wm/{type}.html"
-        unique = str(uuid.uuid4())[:8]
-        hooks = get_hooks(request.user)
-        if type == "page":
-            type = "modal"
-        context = {
-            "title": f"Hooks ({type})",
-            "unique": unique,
-            "window_content": self.window_content,
-            "items": hooks,
-            "type": type,
-        }
-        return render(request, template_name, context)
+    submit_url_name = "hook_create"
 
 
-class HookAction(LoginRequiredMixin, APIView):
-    allowed_types = ["modal", "widget", "window", "page"]
-    window_content = "window-content/add-hook.html"
-    parser_classes = [FormParser]
+class HookCreate(LoginRequiredMixin, ObjectCreate):
+    model = Hook
+    form_class = HookForm
+    context_object_name = "hooks"
+    submit_url_name = "hook_create"
 
-    def get(self, request, type, hook_id=None):
-        """
-        Get the form for adding or editing a hook.
-        :param hook_id: The id of the hook to edit. Optional.
-        """
-        if type not in self.allowed_types:
-            return HttpResponseBadRequest
-        template_name = f"wm/{type}.html"
-        unique = str(uuid.uuid4())[:8]
-        if hook_id:
-            try:
-                hook = Hook.objects.get(id=hook_id, user=request.user)
-                form = HookForm(instance=hook)
-            except Hook.DoesNotExist:
-                message = "Hook does not exist"
-                message_class = "danger"
-                context = {
-                    "message": message,
-                    "message_class": message_class,
-                    "window_content": self.window_content,
-                }
-                return render(request, template_name, context)
-        else:
-            form = HookForm()
-        if type == "page":
-            type = "modal"
-        context = {
-            "form": form,
-            "hook_id": hook_id,
-            "type": type,
-            "unique": unique,
-            "window_content": self.window_content,
-        }
 
-        return render(request, template_name, context)
+class HookUpdate(LoginRequiredMixin, ObjectUpdate):
+    model = Hook
+    form_class = HookForm
+    context_object_name = "hooks"
+    submit_url_name = "hook_update"
 
-    def put(self, request, type, hook_id=None):
-        """
-        Add or edit a hook.
-        :param hook_id: The id of the hook to edit. Optional.
-        """
-        if type not in self.allowed_types:
-            return HttpResponseBadRequest
-        message = None
-        message_class = "success"
 
-        if hook_id:
-            try:
-                form = HookForm(request.data, instance=Hook.objects.get(id=hook_id))
-            except Hook.DoesNotExist:
-                message = "Hook does not exist"
-                message_class = "danger"
-                context = {
-                    "message": message,
-                    "class": message_class,
-                }
-                return render(request, self.template_name, context)
-        else:
-            form = HookForm(request.data)
-        if form.is_valid():
-            hook = form.save(commit=False)
-            hook.user = request.user
-            hook.save()
-            if hook_id:
-                message = f"Hook {hook_id} edited successfully"
-            else:
-                message = f"Hook {hook.id} added successfully"
-        else:
-            message = "Error adding hook"
-            message_class = "danger"
-
-        hooks = get_hooks(request.user)
-
-        context = {
-            "items": hooks,
-            "type": type,
-        }
-        if message:
-            context["message"] = message
-            context["class"] = message_class
-        template_name = "partials/hook-list.html"
-        return render(request, template_name, context)
-
-    def delete(self, request, type, hook_id):
-        """
-        Delete a hook.
-        :param hook_id: The id of the hook to delete.
-        """
-        if type not in self.allowed_types:
-            return HttpResponseBadRequest
-        message = None
-        message_class = "success"
-        try:
-            hook = Hook.objects.get(id=hook_id, user=request.user)
-            hook.delete()
-            message = "Hook deleted successfully"
-        except Hook.DoesNotExist:
-            message = "Error deleting hook"
-            message_class = "danger"
-
-        hooks = get_hooks(request.user)
-
-        context = {
-            "items": hooks,
-            "type": type,
-        }
-        if message:
-            context["message"] = message
-            context["class"] = message_class
-
-        template_name = "partials/hook-list.html"
-        return render(request, template_name, context)
+class HookDelete(LoginRequiredMixin, ObjectDelete):
+    model = Hook