Improve navigating trades and positions by cross-linking

core/views/positions.py

@@ -8,7 +8,7 @@ from rest_framework.parsers import FormParser
 from two_factor.views.mixins import OTPRequiredMixin
 
 from core.exchanges import GenericAPIError
-from core.models import Account
+from core.models import Account, Trade
 from core.util import logs
 
 log = logs.get_logger(__name__)
@@ -28,6 +28,32 @@ def get_positions(user, account_id=None):
     return items
 
 
+def annotate_positions(positions, user, return_order_ids=False):
+    """
+    Annotate positions with trade information.
+    If return_order_ids is True, yield a list of order_ids instead of a list of trades.
+    :param positions: list of positions
+    :param user: user
+    :param return_order_ids: whether to return a generator of order_ids
+    :return: None or list of order_ids
+    :rtype: None or generator
+    """
+    for item in positions:
+        try:
+            if "trade_ids" in item:
+                if return_order_ids:
+                    for trade_id in Trade.objects.filter(
+                        user=user, order_id__in=item["trade_ids"]
+                    ):
+                        yield trade_id.order_id
+                else:
+                    item["trades"] = Trade.objects.filter(
+                        user=user, order_id__in=item["trade_ids"]
+                    )
+        except Trade.DoesNotExist:
+            pass
+
+
 class Positions(LoginRequiredMixin, OTPRequiredMixin, View):
     allowed_types = ["modal", "widget", "window", "page"]
     window_content = "window-content/objects.html"
@@ -41,6 +67,7 @@ class Positions(LoginRequiredMixin, OTPRequiredMixin, View):
         template_name = f"wm/{type}.html"
         unique = str(uuid.uuid4())[:8]
         items = get_positions(request.user, account_id)
+        annotate_positions(items, request.user, return_order_ids=False)
         if type == "page":
             type = "modal"
         context = {
@@ -66,12 +93,15 @@ class PositionAction(LoginRequiredMixin, OTPRequiredMixin, View):
         Get live information for a trade.
         """
         if type not in self.allowed_types:
-            return HttpResponseBadRequest
+            return HttpResponseBadRequest()
         template_name = f"wm/{type}.html"
         unique = str(uuid.uuid4())[:8]
 
         account = Account.get_by_id(account_id, request.user)
         info = account.client.get_position_info(symbol)
+        valid_trade_ids = list(
+            annotate_positions([info], request.user, return_order_ids=True)
+        )
 
         if type == "page":
             type = "modal"
@@ -81,6 +111,7 @@ class PositionAction(LoginRequiredMixin, OTPRequiredMixin, View):
             "window_content": self.window_content,
             "type": type,
             "items": info,
+            "valid_trade_ids": valid_trade_ids,
         }
 
         return render(request, template_name, context)