Fix all tests

handler/lib/agoradesk_py.py

@@ -679,7 +679,6 @@ class AgoraDesk:
             add_to_api_method += f"/{payment_method}"
 
         params = self._generic_search_parameters(amount, page)
-
         return self._api_call(
             api_method=f"{direction}-{main_currency}-online/" f"{exchange_currency}{add_to_api_method}",
             query_values=params,
@@ -688,11 +687,11 @@ class AgoraDesk:
     @staticmethod
     def _generic_search_parameters(amount, page):
         params = None
-        if amount and not page:
+        if amount and page is not None:
             params = {"amount": f"{amount}"}
-        elif amount and page:
+        elif amount and page is not None:
             params = {"amount": f"{amount}", "page": f"{page}"}
-        elif not amount and page:
+        elif not amount and page is not None:
             params = {"page": f"{page}"}
         return params
 

handler/lib/markets.py

@@ -120,12 +120,12 @@ class Markets(util.Base):
             except KeyError:
                 # self.log.error("Error getting public ads for currency {currency}", currency=currency)
                 if currency == "GBP":
-                    self.log.error("Error getting public ads for currency USD, aborting")
+                    self.log.error("Error getting public ads for currency GBP, aborting")
                     break
                 continue
-
             # Filter asset
             public_ads_filtered = [ad for ad in public_ads_currency if ad[4] == asset]
+
             # Filter provider
             public_ads_filtered = [ad for ad in public_ads_filtered if ad[3] == provider]
             our_ads = [ad for ad in public_ads_filtered if ad[1] == username]
@@ -143,7 +143,7 @@ class Markets(util.Base):
                 asset = ad[4]
                 our_margin = ad[5]
                 if new_margin != our_margin:
-                    to_update.append([ad_id, new_formula, asset, currency, False])
+                    to_update.append([str(ad_id), new_formula, asset, currency, False])
 
         return to_update